Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate bindings for global asynchronous functions. #581

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
3 participants
@tmiasko
Copy link
Contributor

tmiasko commented Apr 18, 2018

  • Drop requirement that asynchronous functions have to end in _async.
    D-Bus related functions tend to have _sync version instead.
  • Include global functions in search for finish function.
  • Import modules used by trampolines, glib_ffi for gpointer and
    gobject_ffi for GObject.
Tomasz Miąsko
Generate bindings for global asynchronous functions.
* Drop requirement that asynchronous functions have to end in `_async`.
  D-Bus related functions tend to have `_sync` version instead.
* Include global functions in search for finish function.
* Import modules used by trampolines, glib_ffi for gpointer and
  gobject_ffi for GObject.
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Apr 18, 2018

There's also gtk::print_run_page_setup_dialog_async and gdk_pixbuf::new_from_stream_async

@tmiasko

This comment has been minimized.

Copy link
Contributor Author

tmiasko commented Apr 18, 2018

The new_from_stream_async case should be handled by this. Things like
print_run_page_setup_dialog_async that don't have explicit finish call
shouldn't be affected either way.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Apr 18, 2018

@tmiasko Thanks

2 functions now generated in gio: poll_mountable, dbus_address_get_stream, maybe some more after deignoring.
Commented changes in: glib, gtk, sourceview
Minor change in gdk-pixbuf

@EPashkin EPashkin merged commit f81e31b into gtk-rs:master Apr 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

vhdirk pushed a commit to vhdirk/gir that referenced this pull request Jul 6, 2018

Merge pull request gtk-rs#581 from tmiasko/more-async-functions
Generate bindings for global asynchronous functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.