Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split gir into lib and binary #584

Merged
merged 1 commit into from Apr 19, 2018
Merged

Split gir into lib and binary #584

merged 1 commit into from Apr 19, 2018

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Apr 18, 2018

cc @EPashkin @sdroege @federicomenaquintero

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Apr 18, 2018

@GuillaumeGomez Thanks. Slightly bad that it mixed with errorchain removal, but it looks good for me.

Sorry but after #583 it need another fix

  --> src\xmlparser.rs:95:51
   |
95 |     pub fn attr_from_str<T>(&self, name: &str) -> Result<Option<T>>
   |                                                   ^^^^^^^^^^^^^^^^^ expected 2 type arguments

Loading

@GuillaumeGomez
Copy link
Member Author

@GuillaumeGomez GuillaumeGomez commented Apr 18, 2018

Ah right. At some time I just removed a few things and then I went up until removing all of error-chain... More like a side-effect than a main focus. 😆

Loading

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Apr 19, 2018

Thanks.

Loading

@EPashkin EPashkin merged commit 3bc8eca into gtk-rs:master Apr 19, 2018
2 checks passed
Loading
@sdroege
Copy link
Member

@sdroege sdroege commented Apr 19, 2018

And next step is to move to failure? Not that it's really needed here, all errors are stringly-typed :)

Loading

@GuillaumeGomez GuillaumeGomez deleted the split branch Apr 19, 2018
@GuillaumeGomez
Copy link
Member Author

@GuillaumeGomez GuillaumeGomez commented Apr 19, 2018

I'd prefer to not use anything for error handling until we have a real need for it. :)

Loading

vhdirk pushed a commit to vhdirk/gir that referenced this issue Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants