Skip to content

Split gir into lib and binary#584

Merged
EPashkin merged 1 commit intogtk-rs:masterfrom
GuillaumeGomez:split
Apr 19, 2018
Merged

Split gir into lib and binary#584
EPashkin merged 1 commit intogtk-rs:masterfrom
GuillaumeGomez:split

Conversation

@GuillaumeGomez
Copy link
Member

@EPashkin
Copy link
Member

@GuillaumeGomez Thanks. Slightly bad that it mixed with errorchain removal, but it looks good for me.

Sorry but after #583 it need another fix

  --> src\xmlparser.rs:95:51
   |
95 |     pub fn attr_from_str<T>(&self, name: &str) -> Result<Option<T>>
   |                                                   ^^^^^^^^^^^^^^^^^ expected 2 type arguments

@GuillaumeGomez
Copy link
Member Author

Ah right. At some time I just removed a few things and then I went up until removing all of error-chain... More like a side-effect than a main focus. 😆

@EPashkin
Copy link
Member

Thanks.

@EPashkin EPashkin merged commit 3bc8eca into gtk-rs:master Apr 19, 2018
@sdroege
Copy link
Member

sdroege commented Apr 19, 2018

And next step is to move to failure? Not that it's really needed here, all errors are stringly-typed :)

@GuillaumeGomez GuillaumeGomez deleted the split branch April 19, 2018 08:15
@GuillaumeGomez
Copy link
Member Author

I'd prefer to not use anything for error handling until we have a real need for it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants