Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split gir into lib and binary #584

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Apr 18, 2018

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:split branch from 4b1866c to 0b0036f Apr 18, 2018

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Apr 18, 2018

@GuillaumeGomez Thanks. Slightly bad that it mixed with errorchain removal, but it looks good for me.

Sorry but after #583 it need another fix

  --> src\xmlparser.rs:95:51
   |
95 |     pub fn attr_from_str<T>(&self, name: &str) -> Result<Option<T>>
   |                                                   ^^^^^^^^^^^^^^^^^ expected 2 type arguments

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:split branch from 0b0036f to 73f3cc4 Apr 18, 2018

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Apr 18, 2018

Ah right. At some time I just removed a few things and then I went up until removing all of error-chain... More like a side-effect than a main focus. 😆

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Apr 19, 2018

Thanks.

@EPashkin EPashkin merged commit 3bc8eca into gtk-rs:master Apr 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Apr 19, 2018

And next step is to move to failure? Not that it's really needed here, all errors are stringly-typed :)

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:split branch Apr 19, 2018

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Apr 19, 2018

I'd prefer to not use anything for error handling until we have a real need for it. :)

vhdirk pushed a commit to vhdirk/gir that referenced this pull request Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.