New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support string type override #597

Merged
merged 7 commits into from May 9, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented May 9, 2018

Part of #592
All works fine, but need last attempt to remove ugly code in src/analysis/out_parameters.rs

cc @GuillaumeGomez

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 9, 2018

Member

@sdroege You was right: need only one options to configure switch string between String, PathBuf and OsString

Member

EPashkin commented May 9, 2018

@sdroege You was right: need only one options to configure switch string between String, PathBuf and OsString

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 9, 2018

Member

Looks good to me. That's a great change! :)

Member

GuillaumeGomez commented May 9, 2018

Looks good to me. That's a great change! :)

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege May 9, 2018

Member

Same, thanks :)

Member

sdroege commented May 9, 2018

Same, thanks :)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 9, 2018

Member

Then I merge and update PR for glib, prepare PR for gio

Member

EPashkin commented May 9, 2018

Then I merge and update PR for glib, prepare PR for gio

@EPashkin EPashkin merged commit 6978ad7 into gtk-rs:master May 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin changed the title from WIP: Support string type override to Support string type override May 9, 2018

@EPashkin EPashkin deleted the EPashkin:os_string branch May 9, 2018

vhdirk pushed a commit to vhdirk/gir that referenced this pull request Jul 6, 2018

Merge pull request #597 from EPashkin/os_string
WIP: Support string type override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment