New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async exctraction #602

Merged
merged 2 commits into from May 16, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented May 15, 2018

also ignoring last 10 clippy warnings, since after removing "{}", you will need to quote all curly brackets and make code less readable.

cc @GuillaumeGomez, @sdroege, @antoyo

warning: writing a literal with an empty format string
   --> src\codegen\enums.rs:216:9
    |
216 | /         "        }
217 | |     }
218 | | }
219 | | "
    | |_^
    |
    = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.200/index.html#write_literal
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege May 15, 2018

Member

Looks good, thanks for cleaning up my code :)

Member

sdroege commented May 15, 2018

Looks good, thanks for cleaning up my code :)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 15, 2018

Member

I don't know much about these parts of the code but it looks good to me!

Member

GuillaumeGomez commented May 15, 2018

I don't know much about these parts of the code but it looks good to me!

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 16, 2018

Member

Its time to merge this too.

Member

EPashkin commented May 16, 2018

Its time to merge this too.

@EPashkin EPashkin merged commit 1825132 into gtk-rs:master May 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:async_exctraction branch May 16, 2018

vhdirk pushed a commit to vhdirk/gir that referenced this pull request Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment