New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generating function body when out parameter has reserved name #603

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented May 15, 2018

Closes #601

@russel Please try this

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege May 15, 2018

Member

Looks obviously correct, even if it does not fix @russel's problem

Member

sdroege commented May 15, 2018

Looks obviously correct, even if it does not fix @russel's problem

@russel

This comment has been minimized.

Show comment
Hide comment
@russel

russel May 16, 2018

@EPashkin I normally build gir from master/HEAD. However this pull request is not yet merged. What process would you like me to use to experiment for you?

russel commented May 16, 2018

@EPashkin I normally build gir from master/HEAD. However this pull request is not yet merged. What process would you like me to use to experiment for you?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@russel

This comment has been minimized.

Show comment
Hide comment
@russel

russel May 16, 2018

@EPashkin I am not sure that works. I'll do something the non-GitHub way.

russel commented May 16, 2018

@EPashkin I am not sure that works. I'll do something the non-GitHub way.

@russel

This comment has been minimized.

Show comment
Hide comment
@russel

russel May 16, 2018

I cloned @EPashkin GitHub repository, built the fix_out_parameter_type branch and it seems to have fixed the problem I had with the parameter named type_.

russel commented May 16, 2018

I cloned @EPashkin GitHub repository, built the fix_out_parameter_type branch and it seems to have fixed the problem I had with the parameter named type_.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 16, 2018

Member

@russel Thanks for checking, then I merge

Member

EPashkin commented May 16, 2018

@russel Thanks for checking, then I merge

@EPashkin EPashkin merged commit 47ba509 into gtk-rs:master May 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:fix_out_parameter_type branch May 16, 2018

vhdirk pushed a commit to vhdirk/gir that referenced this pull request Jul 6, 2018

Merge pull request #603 from EPashkin/fix_out_parameter_type
Fix generating function body when out parameter has reserved name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment