New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings about passing short and Copy arguments by reference #613

Merged
merged 1 commit into from Jun 23, 2018

Conversation

Projects
None yet
3 participants
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 22, 2018

Member

@GuillaumeGomez Changes is trivial so I merge when CI passed

Member

EPashkin commented Jun 22, 2018

@GuillaumeGomez Changes is trivial so I merge when CI passed

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 22, 2018

Member

Sound good

Member

sdroege commented Jun 22, 2018

Sound good

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 22, 2018

Member

Seems travis broke all nighly rust, I emailed its to travis support, they are working on this

Member

EPashkin commented Jun 22, 2018

Seems travis broke all nighly rust, I emailed its to travis support, they are working on this

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 22, 2018

Member

That's weird... Well, I let you handle the merge in any case. :)

Member

GuillaumeGomez commented Jun 22, 2018

That's weird... Well, I let you handle the merge in any case. :)

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 22, 2018

Member

That's probably rust-lang/rust#51699

Member

sdroege commented Jun 22, 2018

That's probably rust-lang/rust#51699

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 22, 2018

Member

@sdroege Thanks for find it.

Member

EPashkin commented Jun 22, 2018

@sdroege Thanks for find it.

@EPashkin EPashkin merged commit 84a701c into gtk-rs:master Jun 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:fix_clippy branch Jun 23, 2018

vhdirk pushed a commit to vhdirk/gir that referenced this pull request Jul 6, 2018

Merge pull request #613 from EPashkin/fix_clippy
Fix clippy warnings about passing short and Copy arguments by reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment