New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent some useless generations #620

Merged
merged 2 commits into from Jul 5, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Jul 3, 2018

However before merging, I'd like to be able to confirm that it works (on GObject) but I wasn't able to generate the GObject files for some reason... Am I missing something?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 4, 2018

Member

Updated! Once merged, I'll send the update for glib.

Member

GuillaumeGomez commented Jul 4, 2018

Updated! Once merged, I'll send the update for glib.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 5, 2018

Member

@GuillaumeGomez Thanks, 👍

Member

EPashkin commented Jul 5, 2018

@GuillaumeGomez Thanks, 👍

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 5, 2018

Member

@EPashkin Should we merge it then?

Member

GuillaumeGomez commented Jul 5, 2018

@EPashkin Should we merge it then?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 5, 2018

Member

Yes

Member

EPashkin commented Jul 5, 2018

Yes

@EPashkin EPashkin merged commit d0f0425 into gtk-rs:master Jul 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:prevent-useless-generation branch Jul 5, 2018

vhdirk pushed a commit to vhdirk/gir that referenced this pull request Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment