Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate glib::Quark based ErrorDomain for enums #624

Merged
merged 1 commit into from Jul 29, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

EPashkin commented Jul 29, 2018

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jul 29, 2018

Affected crates besides glib: gdk, gdk-pixbuf, gio, gtk
I plan add PRs for first four (CI will fails) and add gtk after its merged.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 29, 2018

Good for me, let's get this done :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jul 29, 2018

Good for me too. Thanks @EPashkin!

@EPashkin EPashkin merged commit bec7561 into gtk-rs:master Jul 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:error_domain_quark branch Jul 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.