New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not bound functions and methods filtering #635

Merged
merged 1 commit into from Sep 2, 2018

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Sep 1, 2018

I completely failed my previous PR (only tested it on sourceview, shame on me...). However I still have an issue: some types have a ns_id equal to 0. Therefore, the filtering is failing because the full name doesn't match (* instead of Gtk for example). For example we have this issue for:

Gtk.TextIter::get_marks because of *.TextMark

Any idea @EPashkin?

Show outdated Hide outdated src/library.rs
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Sep 1, 2018

Member

@EPashkin: All fixed, thanks a lot, wonderful idea!

Member

GuillaumeGomez commented Sep 1, 2018

@EPashkin: All fixed, thanks a lot, wonderful idea!

Show outdated Hide outdated src/library.rs
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Sep 2, 2018

Member

Updated.

Member

GuillaumeGomez commented Sep 2, 2018

Updated.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin
Member

EPashkin commented Sep 2, 2018

@EPashkin EPashkin merged commit d3116ca into gtk-rs:master Sep 2, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:fix-function-method-not-bound branch Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment