Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generare notify for ConstructOnly properties #641

Merged
merged 2 commits into from Sep 29, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

EPashkin commented Sep 29, 2018

Part of #510

cc @GuillaumeGomez , @sdroege

Affected crates glib, gtk, gio, gdk, gdk-pixbuf, sourceview

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 29, 2018

As long as this still allows to explicitly enable the notify functions via the toml file, I'm ok with this

);
}
readable &= generate.contains(PropertyGenerateFlags::GET);
writable &= generate.contains(PropertyGenerateFlags::SET);
let notifable = generate.contains(PropertyGenerateFlags::NOTIFY);
if generate_set {
notifable = generate.contains(PropertyGenerateFlags::NOTIFY);

This comment has been minimized.

@EPashkin

EPashkin Sep 29, 2018

Author Member

Yes, it allow 😉

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Sep 29, 2018

👍

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Sep 29, 2018

Updated, I forgot to remove notify trampolines in #640 if notify not generated.

@EPashkin EPashkin force-pushed the EPashkin:dont_generate_notify_for_constructonly_properties branch from b659693 to 0e16057 Sep 29, 2018

@EPashkin EPashkin merged commit c385982 into gtk-rs:master Sep 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:dont_generate_notify_for_constructonly_properties branch Sep 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.