Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display and strenghten CI #663

Merged
merged 2 commits into from Nov 16, 2018
Merged

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 16, 2018

No description provided.

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Nov 16, 2018

@GuillaumeGomez Thanks. Just waiting CI.
Feel free to merge if you want speedup process or just see that CI passed.

@GuillaumeGomez
Copy link
Member Author

@GuillaumeGomez GuillaumeGomez commented Nov 16, 2018

Ok, thanks! :)

@sdroege
Copy link
Member

@sdroege sdroege commented Nov 16, 2018

👍

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:fix-display branch from f1e0989 to e88fed7 Nov 16, 2018
@EPashkin
Copy link
Member

@EPashkin EPashkin commented Nov 16, 2018

Strange, now I get error in glib: only impl fmt::Display for Binding generated without use std::fmt;

  --> D:/eap/rust/0/glib\src\gobject\auto\binding.rs:64:6
   |
64 | impl fmt::Display for Binding {
   |      ^^^ Use of undeclared type or module `fmt`

error[E0433]: failed to resolve. Use of undeclared type or module `fmt`
@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:fix-display branch from e88fed7 to 2778f47 Nov 16, 2018
@GuillaumeGomez
Copy link
Member Author

@GuillaumeGomez GuillaumeGomez commented Nov 16, 2018

@EPashkin thanks, taking a look!

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Nov 16, 2018

@GuillaumeGomez Ignore it, just missed local change 😭

@GuillaumeGomez
Copy link
Member Author

@GuillaumeGomez GuillaumeGomez commented Nov 16, 2018

I was wondering what I was missing haha.

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:fix-display branch from 2778f47 to 1a5313d Nov 16, 2018
@GuillaumeGomez GuillaumeGomez merged commit 17bb021 into gtk-rs:master Nov 16, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:fix-display branch Nov 16, 2018
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 16, 2018
@EPashkin EPashkin mentioned this pull request Nov 17, 2018
@GuillaumeGomez GuillaumeGomez changed the title Fix display Fix display and strenghten CI Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.