Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display and strenghten CI #663

Merged
merged 2 commits into from
Nov 16, 2018

Conversation

GuillaumeGomez
Copy link
Member

No description provided.

@EPashkin
Copy link
Member

@GuillaumeGomez Thanks. Just waiting CI.
Feel free to merge if you want speedup process or just see that CI passed.

@GuillaumeGomez
Copy link
Member Author

Ok, thanks! :)

@sdroege
Copy link
Member

sdroege commented Nov 16, 2018

👍

@EPashkin
Copy link
Member

Strange, now I get error in glib: only impl fmt::Display for Binding generated without use std::fmt;

  --> D:/eap/rust/0/glib\src\gobject\auto\binding.rs:64:6
   |
64 | impl fmt::Display for Binding {
   |      ^^^ Use of undeclared type or module `fmt`

error[E0433]: failed to resolve. Use of undeclared type or module `fmt`

@GuillaumeGomez
Copy link
Member Author

@EPashkin thanks, taking a look!

@EPashkin
Copy link
Member

@GuillaumeGomez Ignore it, just missed local change 😭

@GuillaumeGomez
Copy link
Member Author

I was wondering what I was missing haha.

@GuillaumeGomez GuillaumeGomez merged commit 17bb021 into gtk-rs:master Nov 16, 2018
@GuillaumeGomez GuillaumeGomez deleted the fix-display branch November 16, 2018 16:04
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 16, 2018
@EPashkin EPashkin mentioned this pull request Nov 17, 2018
@GuillaumeGomez GuillaumeGomez changed the title Fix display Fix display and strenghten CI Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants