Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basics for subclassing #669

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@sdroege
Copy link
Member

sdroege commented Nov 19, 2018

This passes the Rust class struct to glib_wrapper! if configured to do
so but still requires it to be manually implemented for the time being.

See gtk-rs/glib#392

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Nov 19, 2018

Example usage is here https://gitlab.freedesktop.org/slomo/gstreamer-rs/commit/735a09e2224d390d9253b24d52e69156d72b4d41

Later I'd like to automatically generate the class structs but that will have to wait a while. It's on my list after I've ported all the GStreamer things though, so next week or the week after probably.

Generally, I'd like to do the next steps gradually, one by one, so it would be good to have this merged before everything is in place already.

Show resolved Hide resolved src/analysis/object.rs Outdated
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 19, 2018

Looks very good, thanks

@sdroege sdroege force-pushed the sdroege:subclass-basics branch 2 times, most recently from 8fc9133 to a4d8197 Nov 19, 2018

Show resolved Hide resolved src/analysis/object.rs Outdated
Implement basics for subclassing
This passes the Rust class struct to glib_wrapper! if configured to do
so but still requires it to be manually implemented for the time being.

@sdroege sdroege force-pushed the sdroege:subclass-basics branch from a4d8197 to e90ceae Nov 20, 2018

@EPashkin EPashkin merged commit 2bb48b9 into gtk-rs:master Nov 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.