Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark autogenerated files as such #679

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
3 participants
@kornelski
Copy link
Contributor

kornelski commented Dec 20, 2018

No description provided.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 21, 2018

Thanks notice this, but better use try!(general::start_comments(w, &env.config)); instead.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Dec 21, 2018

👍 once @EPashkin's change is done :) Thanks!

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 5, 2019

@kornelski If you don't have time to fix PR, I will add replacement PR on next Monday.

@kornelski kornelski force-pushed the kornelski:donotedit branch 2 times, most recently from 72dd8ea to 5120383 Jan 5, 2019

@kornelski

This comment has been minimized.

Copy link
Contributor Author

kornelski commented Jan 5, 2019

I've updated the PR

try!(write!(
w,
"{}",
r##"extern crate pkg_config;
r##"

This comment has been minimized.

@EPashkin

EPashkin Jan 5, 2019

Member

Please make only one empty line with try!(writeln!(w)); instead

This comment has been minimized.

@kornelski

kornelski Jan 5, 2019

Author Contributor

That's weird. Why?

(also why use try! when the crate requires Rust 1.19?)

This comment has been minimized.

@EPashkin

EPashkin Jan 5, 2019

Member

One line because it how is now in all generated files.

try replacement need too many changes now 😭

This comment has been minimized.

@kornelski

kornelski Jan 5, 2019

Author Contributor

Updated PR

@kornelski kornelski force-pushed the kornelski:donotedit branch from 5120383 to 7335802 Jan 5, 2019

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 5, 2019

@kornelski Thanks, waiting for CI just in case.
After merge I will add PR in sys

@EPashkin EPashkin merged commit 11adffa into gtk-rs:master Jan 5, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@kornelski kornelski deleted the kornelski:donotedit branch Jan 5, 2019

@EPashkin EPashkin referenced this pull request Jan 5, 2019

Merged

Regen #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.