Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly cast pointers in property getters/setters if no trait is to… #692

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
2 participants
@sdroege
Copy link
Member

sdroege commented Jan 16, 2019

… be generated

Needed for GStreamer but didn't appear anywhere in the gtk-rs crates

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 16, 2019

@sdroege Thanks.
PR don't do any changes in gtk-rs, I just waiting CI.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 16, 2019

It's not complete yet, ObjectType import is missing sometimes. Fixing :)

@sdroege sdroege force-pushed the sdroege:property-getters-setters-cast branch from dd6b34a to dd6fb0a Jan 16, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 16, 2019

now it's good

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 16, 2019

Thanks

@EPashkin EPashkin merged commit 2f0a317 into gtk-rs:master Jan 16, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.