Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for known subtypes when deciding if a type is a final type #698

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
2 participants
@sdroege
Copy link
Member

sdroege commented Jan 22, 2019

If there's a subtype we don't consider it a final type too. The class
struct might be private but inside the library there might be subtypes.

Subtypes in other libraries are nonetheless not possible if the class
struct is private.


I forgot to add that back yesterday. I don't think this changes any generated code except for gstreamer-pbutils

Check for known subtypes when deciding if a type is a final type
If there's a subtype we don't consider it a final type too. The class
struct might be private but inside the library there might be subtypes.

Subtypes in other libraries are nonetheless not possible if the class
struct is private.
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 22, 2019

@sdroege Thanks.
In gtk-rs only affected gdk_pixbuf::PixbufAnimation in GtkImage

@EPashkin EPashkin merged commit bbf0f44 into gtk-rs:master Jan 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.