Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid gboolean generation #699

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jan 22, 2019

When generating glib, I had a "little" issue because of this one.

cc @EPashkin

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 22, 2019

👍

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 22, 2019

@GuillaumeGomez Thanks.
I merge this but IMHO all idle_* and timeout_ in glib need be manual as return SourceId

@EPashkin EPashkin merged commit e90e5f9 into gtk-rs:master Jan 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:missing-namespace branch Jan 22, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jan 22, 2019

We still have issues with g_child_watch_add* because of aliases. I'm ending the patch then here we go!

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 22, 2019

All those source/watch related things have to be manually written (and are already).

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 22, 2019

All those source/watch related things have to be manually written (and are already).

Among other things, they only require Send for the closure, can be FnMut() (and are already), return a SourceId and the closure returns a Continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.