Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imports for async out parameters #700

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

EPashkin commented Jan 22, 2019

Fix #693

@vhdirk Please check results, no use std::mem deletion for now

@GuillaumeGomez There no changes in gtk-rs

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 22, 2019

👍

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 24, 2019

@EPashkin let's get this in?

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jan 24, 2019

Before I add PR to check that webkit2gtk-rs builds

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 24, 2019

Fine with me :) But the change looks correct regardless of whether it fixes all of the webkit2gtk problems are not, that's why I was wondering why not just merge it already anyway.

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jan 24, 2019

Because it has no effect to gtk-rs it may be not do enough.

@EPashkin EPashkin referenced this pull request Jan 24, 2019

Merged

Regen #46

@EPashkin EPashkin merged commit beae3da into gtk-rs:master Jan 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:analyze_async_out_parameters branch Jan 24, 2019

@vhdirk

This comment has been minimized.

Copy link

vhdirk commented Jan 24, 2019

Sorry, I've been busy.
Just regenerated webkit2gtk with this and works all fine now. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.