Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references from TypeId usage #703

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

EPashkin commented Jan 22, 2019

.. with clippy help

cc @GuillaumeGomez, @sdroege

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 22, 2019

Oh indeed, thanks a lot!

for (tid, _) in self.types() {
if let Type::Class(ref class) = *self.type_(tid) {
if class.parent.as_ref() == Some(parent_tid) {
if class.parent == Some(parent_tid) {

This comment has been minimized.

@sdroege

sdroege Jan 22, 2019

Member

I forgot to add a TODO comment here. I think we want to move the class_hierarchy generation into postprocessing at some point, and then directly make use of the result of it here. Otherwise we have a O(n²) loop here and in the class hierarchy code.

This comment has been minimized.

@EPashkin

EPashkin Jan 22, 2019

Author Member

Added FIXME

This comment has been minimized.

@sdroege

sdroege Jan 22, 2019

Member

Thanks :) All good then

This comment has been minimized.

@EPashkin

EPashkin Jan 22, 2019

Author Member

Sourceview postprocessing take only 10msec from 1.6s total 😉

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Jan 22, 2019

Member

Oh wow. That's A LOT!

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 22, 2019

👍

@EPashkin EPashkin force-pushed the EPashkin:clippy branch from 6f2be0f to 40dc0b3 Jan 22, 2019

@EPashkin EPashkin merged commit 1ebbd5f into gtk-rs:master Jan 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:clippy branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.