Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual traits #707

Merged
merged 1 commit into from Jan 27, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

EPashkin commented Jan 26, 2019

Part of #683

currently only support traits from current crate
and don't use parents manual traits at all (so it need be added manually)

@EPashkin EPashkin force-pushed the EPashkin:manual_traits branch from f366dad to 9cee3fc Jan 27, 2019

@EPashkin EPashkin changed the title WIP: Add manual traits Add manual traits Jan 27, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jan 27, 2019

This is final version, support using parent traits and traits from other crates. All changes in configs linked to issue except gdk (it have only one manual trait)

@GuillaumeGomez, @sdroege Please take look when you have time.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 27, 2019

Looks good to me, thanks!

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jan 27, 2019

Lets merge this too

@EPashkin EPashkin merged commit 76da22e into gtk-rs:master Jan 27, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@EPashkin EPashkin deleted the EPashkin:manual_traits branch Jan 27, 2019

name = "Gtk.Application"
status = "generate"
#add link to trait from other crate
manual_traits = ["gio::ApplicationExtManual"]

This comment has been minimized.

@sdroege

sdroege Jan 28, 2019

Member

I don't like this very much but don't have a better idea. Ideally we should be able to re-use the information from the Gir.toml of gio here but we don't have that...

name = "Gtk.Assistant"
status = "generate"
#add link to trait from current crate
manual_traits = ["AssistantExtManual"]

This comment has been minimized.

@sdroege
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.