Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Into trait generation #724

Merged
merged 1 commit into from Feb 23, 2019

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

commented Feb 22, 2019

Fixes #722

It doesn't fix the whole None::<Whatever> issue but I guess it's a first step? The goal here being to go back to more explicit code.

cc @sdroege @EPashkin

@sdroege

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Need to look at generated code but a big 👍 for the intention here at least :) Thanks for working on this

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2019

That makes me very sad that we reached rust's limit so quickly...

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2019

You can take a look at the result here.

@EPashkin EPashkin referenced this pull request Feb 23, 2019

Closed

Remove `Into` trait #722

@sdroege

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

In #722 @EPashkin wrote

if we want remove it, then instead complete removal like in #724,
we better remove it only for non-final objects and maybe for function too (if there any),
in other cases Into works fine.

The point of this PR here is not to fix the problem with IsA, it's completely unrelated. It makes the compiler errors slightly less confusing but that's about it.

As @GuillaumeGomez wrote in the initial comment here: "The goal here being to go back to more explicit code."

@EPashkin

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

As @sdroege also for this solution, then lets merge this.
@GuillaumeGomez Thanks

@EPashkin EPashkin merged commit 253cff1 into gtk-rs:master Feb 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez referenced this pull request Feb 23, 2019

Merged

Fixup #728

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:into-removal branch Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.