Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recheck crate names usage #734

Merged
merged 3 commits into from Mar 5, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

commented Mar 3, 2019

Fix #731

No changes in current gtk-rs

cc @GuillaumeGomez, @sdroege

@EPashkin EPashkin force-pushed the EPashkin:crate_package branch from b1ca3b1 to 39d85b2 Mar 3, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

👍

@@ -42,6 +42,20 @@ pub fn crate_name(name: &str) -> String {
}
}

pub fn exported_crate_name(crate_name: &str) -> String {

This comment has been minimized.

Copy link
@sdroege

sdroege Mar 4, 2019

Member

Maybe add some docs to these functions here to explain what they are actually returning and in which context that returned string is used

This comment has been minimized.

Copy link
@EPashkin

EPashkin Mar 4, 2019

Author Member

Updated

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

Looks good to me otherwise

@EPashkin EPashkin merged commit 8d7ac9f into gtk-rs:master Mar 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:crate_package branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.