Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use "ffi" suffix for sys crates #737

Merged
merged 2 commits into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

commented Mar 5, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

👍

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

See https://github.com/gtk-rs/glib/pull/470/files#r262832438 , otherwise looks all good to me.

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

See https://github.com/gtk-rs/glib/pull/470/files#r262832438 , otherwise looks all good to me.

I.e., I'd prefer if we also changed sys to $crate_name_sys so that no renaming at all is necessary anymore.

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

Ready for final check

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

👍

@EPashkin EPashkin merged commit 44398d6 into gtk-rs:master Mar 7, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@EPashkin EPashkin deleted the EPashkin:ffi_to_sys branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.