Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crate name fix for webkit2xx #745

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
2 participants
@EPashkin
Copy link
Member

commented Mar 27, 2019

web_kit2_sys and web_kit2_web_extension_sys looks ugly

@EPashkin EPashkin force-pushed the EPashkin:fix_webkit2_sys_crate_name branch from 3ec3956 to 0047797 Mar 27, 2019

@EPashkin EPashkin changed the title Add harcoded crate name fix for webkit2xx Add crate name fix for webkit2xx Mar 27, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

Added config option to override crate names

@EPashkin EPashkin referenced this pull request Mar 27, 2019

Merged

Regen #49

@EPashkin EPashkin force-pushed the EPashkin:fix_webkit2_sys_crate_name branch 2 times, most recently from 6294d96 to 7b695ce Mar 27, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

@GuillaumeGomez and @sdroege: maybe there better way to do this?
And please check added text in readme.md

README.md Outdated

### Crate name overrides

`gir` uses simple rule to convert namespace to crate name and it sometimes go wrong, Ex. "WebKit2WebExtension" namespace converted to "web_kit2_web_extension" crate name that looks bad.

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Mar 27, 2019

Member

With corrections:

`gir` uses simple rule to convert a namespace to a crate name and it sometimes goes wrong. For example, "WebKit2WebExtension" namespace will be converted to "web_kit2_web_extension", which looks bad.
README.md Outdated

`gir` uses simple rule to convert namespace to crate name and it sometimes go wrong, Ex. "WebKit2WebExtension" namespace converted to "web_kit2_web_extension" crate name that looks bad.

To fix it table `crate_name_overrides` can be used.

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Mar 27, 2019

Member
To fix it, the `crate_name_overrides` option can be used.
README.md Outdated

To fix it table `crate_name_overrides` can be used.

This also replaces name FFI crates.

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Mar 27, 2019

Member
This also replace FFI crates' name.

This comment has been minimized.

Copy link
@EPashkin

EPashkin Mar 27, 2019

Author Member

"'" really needed?

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Mar 27, 2019

Member

Yes, it's to mark "possession". But if someone else could confirm it maybe?

This comment has been minimized.

Copy link
@EPashkin

EPashkin Mar 27, 2019

Author Member

Thanks, I didn't know that this case is possible "We use ’s after a singular noun and ’ after a plural noun."

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

@EPashkin EPashkin force-pushed the EPashkin:fix_webkit2_sys_crate_name branch from 7b695ce to a2a3b60 Mar 27, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

Updated

README.md Outdated

To fix it, the `crate_name_overrides` option can be used.

This also replace FFI crates name.

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Mar 27, 2019

Member

The ' after "crates" is important. Copy and paste it. ;)

It also replaces FFI crates' name.

This comment has been minimized.

Copy link
@EPashkin

EPashkin Mar 27, 2019

Author Member

Done

@EPashkin EPashkin force-pushed the EPashkin:fix_webkit2_sys_crate_name branch from a2a3b60 to 3248028 Mar 27, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Looks good to me, thanks!

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

Ok, lets merge then

@EPashkin EPashkin merged commit 16d8c2d into gtk-rs:master Mar 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:fix_webkit2_sys_crate_name branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.