Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gir errors a bit #766

Merged
merged 2 commits into from May 16, 2019

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Copy link
Member

commented May 15, 2019

Part of #681.

cc @bochecha @EPashkin @sdroege

Errors look like this now (not much changes but that's a start!):

GirXml: ../gir-files/GLib-2.0.gir at line 31840:10: <type> element is missing a name attribute
@EPashkin

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Hm, stable and nightly has different formatting rules
@GuillaumeGomez Thanks for fixes.
Can you do cargo +stable fmt ?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

Arf, cargo fmt is on the run!

fmt

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:errors branch from 0b0d118 to 2afa869 May 16, 2019

@EPashkin

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Good that it was just unformated.
@GuillaumeGomez Thanks

@EPashkin EPashkin merged commit 75915f1 into gtk-rs:master May 16, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:errors branch May 16, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

I can predict that a lot of my future pull requests will have this issue. :-°

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.