Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports handling #774

Merged
merged 1 commit into from May 19, 2019

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Copy link
Member

commented May 18, 2019

Fixes #773.

cc @sdroege @EPashkin

@GuillaumeGomez GuillaumeGomez referenced this pull request May 18, 2019

Merged

Generate new types #213

.or_insert((version, Vec::new()));
// Since there is no constraint on this import, if any constraint
// is needed, we can just remove it.
entry.1 = Vec::new();

This comment has been minimized.

Copy link
@EPashkin

EPashkin May 19, 2019

Member

Or call clear

This comment has been minimized.

Copy link
@EPashkin

EPashkin May 19, 2019

Member

or set Vec::new instead clear in add too.

@EPashkin

This comment has been minimized.

Copy link
Member

commented May 19, 2019

@GuillaumeGomez Thanks, import part looks good.

Part related to gtk-rs/gtk#615 is unfinished?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented May 19, 2019

gtk-rs/gtk#615 is "finished": we need to regenerate docs and release a new version of lgpl-docs (and there is no connection to this current PR).

@EPashkin

This comment has been minimized.

Copy link
Member

commented May 19, 2019

@GuillaumeGomez I meant that this PR contains only debug prints in src/codegen/doc/mod.rs

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:fix-imports-handling branch from f72a59f to 48d65ff May 19, 2019

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:fix-imports-handling branch from 48d65ff to 08933c5 May 19, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented May 19, 2019

Oh crap! Completely forgot to remove them... Done! And yes, I was trying to figure out why we had this issue. It's not an issue anymore, just need a rebuild.

@EPashkin EPashkin merged commit 1599d2d into gtk-rs:master May 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:fix-imports-handling branch May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.