Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trait object warning for futures #790

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Copy link
Member

commented Jun 5, 2019

Fixes #789.

As far as I can tell, only gtk is impacted (in src/auto/icon_info.rs).

cc @EPashkin @sdroege

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thanks
Affected by gir: gtk, gio, webkit2gtk-rs, gdk-pixbuf
Also need dyn in manual parts: glib, examples

@EPashkin EPashkin merged commit 44bbff0 into gtk-rs:master Jun 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:dyn-future branch Jun 5, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

For glib, gtk-rs/glib#491 is open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.