Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing callback parameter handling #791

Merged

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

commented Jun 7, 2019

Fixes #783.

Now the new "issue" is:

libgir::analysis::functions] measure_disk_usage_async: Cannot handle callbacks and async parameters at the same time for the moment

馃ぃ

cc @EPashkin @sdroege

@sdroege

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

馃憤

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

@GuillaumeGomez Thanks, do you want me to merge now or there will be updates?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

For me it's good, unless you saw something missing?

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

This change not generated any new function in gtk-rs, so it is possible that you want to update 馃槈
Thanks, I will merge now

@EPashkin EPashkin merged commit d2f586f into gtk-rs:master Jun 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:missing-callback-parameter-handling branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.