Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate trampolines directly inside functions #792

Merged
merged 1 commit into from Jun 8, 2019

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

commented Jun 7, 2019

Fixes #664.

You can check the generated code here.

cc @EPashkin @sdroege

@sdroege

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Generated code looks good, thanks :)

@@ -24,9 +24,8 @@ pub fn generate(
env: &Env,
analysis: &Trampoline,
in_trait: bool,
object_name: &str,
prepend: &str,

This comment has been minimized.

Copy link
@EPashkin

EPashkin Jun 8, 2019

Member

IMHO here better be indent: usize as it public function and prepend can stay in inner privates.

This comment has been minimized.

Copy link
@EPashkin

EPashkin Jun 8, 2019

Member

I don't insist

This comment has been minimized.

Copy link
@EPashkin

EPashkin Jun 8, 2019

Member

Hm, all version_condition in this file need indent

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Jun 8, 2019

Author Member

Ok, I'll udpate it!

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Only small nit and cargo fmt run.

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:move-trampolines branch from 3f0c069 to f758153 Jun 8, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

Updated.

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

@EPashkin EPashkin merged commit 1dbb0ee into gtk-rs:master Jun 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:move-trampolines branch Jun 8, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

Time for generations!

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

All PRs are now open!

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

👍 for all linked PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.