Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for init/clear function expressions of boxed types #793

Merged
merged 2 commits into from Jun 10, 2019

Conversation

Projects
None yet
2 participants
@sdroege
Copy link
Member

commented Jun 10, 2019

Fixes https://github.com/gtk-rs/glib/issues/469
@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Please update Readme.txt maybe with TreeIter as example

Show resolved Hide resolved src/codegen/general.rs Outdated

@sdroege sdroege force-pushed the sdroege:init-functions branch from 8db10a4 to 4ba5b96 Jun 10, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

Please update Readme.txt maybe with TreeIter as example

Done

@sdroege sdroege force-pushed the sdroege:init-functions branch from 4ba5b96 to 2bce1fc Jun 10, 2019

.map(ToOwned::to_owned);

if (init_function_expression.is_some() && clear_function_expression.is_none())
|| (init_function_expression.is_none() && clear_function_expression.is_some())

This comment has been minimized.

Copy link
@EPashkin

EPashkin Jun 10, 2019

Member

Maybe init_function_expression.is_some() != clear_function_expression.is_some() ?

This comment has been minimized.

Copy link
@sdroege

sdroege Jun 10, 2019

Author Member

I dislike comparing booleans with == and != :)

This comment has been minimized.

Copy link
@EPashkin

EPashkin Jun 10, 2019

Member

Ok, then I wait for CI and merge

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@sdroege Thanks

@EPashkin EPashkin merged commit e586ff8 into gtk-rs:master Jun 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

sdroege added a commit to sdroege/gtk-rs that referenced this pull request Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.