Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle glib::Pid conversions specifically #817

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jul 22, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 22, 2019

I updated gtk-rs/gio#230 so you can see this change too.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 22, 2019

Generated code looks good to me

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:pid-special-handling branch from 9fe8749 to 1f48666 Jul 22, 2019
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 22, 2019

@GuillaumeGomez Thanks, I merge this as is. but, please, don't forget to fix it in glib::spawn_async too

@EPashkin EPashkin merged commit c697eaf into gtk-rs:master Jul 22, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:pid-special-handling branch Jul 23, 2019
@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 23, 2019

@EPashkin I'll create an issue just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.