Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle doc generation for docs.rs #820

Merged
merged 1 commit into from Jul 26, 2019

Conversation

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jul 23, 2019

Fixes #818.

I'm pretty sure I'm forgetting something here though... Well it's late, I'll see that tomorrow...

cc @EPashkin @sdroege

src/codegen/sys/build.rs Outdated Show resolved Hide resolved
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 24, 2019

@GuillaumeGomez Thanks, LGFM
IMHO only possible addition is updating "README.md"

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 24, 2019

No, I just remembered! I need to add in the features the highest version and "dox".

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:docs.rs-handling branch from 52ee006 to 9fdb726 Jul 24, 2019
@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 24, 2019

Ok, I think it's ready now. We'll need to add "embed-lgpl-docs" to the features to be added for gtk-rs non-sys crates but that's it.

src/codegen/sys/cargo_toml.rs Outdated Show resolved Hide resolved
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 24, 2019

It is great idea to add highest version, thanks

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 25, 2019

Shouldn't we by default just add all features apart from purge-lgpl-docs? That's the right thing for almost every crate.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 25, 2019

The lgpl-* features aren't part of sys crates and should be provided through the new option. Also, I'm not a big fan of adding all features. For instance, versions "contain" lower versions so it'd just be noise.

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:docs.rs-handling branch from 9fdb726 to e2a1328 Jul 25, 2019
@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 25, 2019

Updated.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 26, 2019

@EPashkin EPashkin merged commit a81dc29 into gtk-rs:master Jul 26, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:docs.rs-handling branch Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.