Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some duplicate clone calls #852

Merged
merged 2 commits into from Oct 19, 2019
Merged

Remove some duplicate clone calls #852

merged 2 commits into from Oct 19, 2019

Conversation

@alex179ohm
Copy link
Contributor

alex179ohm commented Oct 19, 2019

Hi guys, I just started learning the code and I found some duplicate clone calls.
Maybe this pr can help

@@ -85,7 +85,7 @@ fn analyze_property(
configured_properties: &[&config::properties::Property],
imports: &mut Imports,
) -> Option<Property> {
let name = prop.name.clone();
//let name = prop.name.clone();

This comment has been minimized.

Copy link
@EPashkin

EPashkin Oct 19, 2019

Member

Seems this line can be removed too

This comment has been minimized.

Copy link
@alex179ohm

alex179ohm Oct 19, 2019

Author Contributor

Ouch, Tanx :)

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Oct 19, 2019

@alex179ohm Thanks

@EPashkin EPashkin merged commit 7f059cc into gtk-rs:master Oct 19, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin EPashkin mentioned this pull request Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.