Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic parameters to builder methods #853

Merged
merged 2 commits into from Oct 19, 2019

Conversation

antoyo
Copy link
Member

@antoyo antoyo commented Oct 19, 2019

@antoyo antoyo force-pushed the fix/generic-builder-methods branch from d626e44 to 490c36f Compare Oct 19, 2019
@@ -98,14 +99,21 @@ fn analyze_property(
if !for_builder {
return None;
}
if let Ok(ref s) = used_rust_type(env, prop.typ, false) {
let type_str = used_rust_type(env, prop.typ, false);
if let Ok(ref s) = type_str {
if !s.contains("GString") {
imports.add_used_type_with_version(s, prop_version);
Copy link
Member

@EPashkin EPashkin Oct 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add set_defaults before this if, and just add_used_type, then imports.add("glib::object::IsA"); will have same version

@EPashkin
Copy link
Member

EPashkin commented Oct 19, 2019

@antoyo LGFM, Thanks. Only one small nit

@antoyo
Copy link
Member Author

antoyo commented Oct 19, 2019

@EPashkin: Please tell me if I did the correct change in the last commit.

@EPashkin
Copy link
Member

EPashkin commented Oct 19, 2019

@antoyo Yes, thanks. Just waiting CI

@EPashkin EPashkin merged commit 306a5d5 into gtk-rs:master Oct 19, 2019
2 checks passed
@EPashkin EPashkin mentioned this pull request Oct 19, 2019
@antoyo antoyo deleted the fix/generic-builder-methods branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants