Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid import add #858

Merged
merged 3 commits into from Oct 22, 2019
Merged

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 21, 2019

Fixes gtk-rs/gtk#872
Fixes #735

cc @sdroege @EPashkin

@sdroege
Copy link
Member

@sdroege sdroege commented Oct 21, 2019

That's covering all of #735 ?

@GuillaumeGomez
Copy link
Member Author

@GuillaumeGomez GuillaumeGomez commented Oct 21, 2019

I didn't check on gstreamer. I doubt it'd work as is though. I can extend it if you want.

@sdroege
Copy link
Member

@sdroege sdroege commented Oct 21, 2019

Please do, would be nice to get rid of all those unused GString imports

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Oct 21, 2019

@GuillaumeGomez You don't know which function added this import in calendar?
I don't see any function with string :(
I worry that we don't add import "String" in some cases (I not found that case in gtk-rs).

@GuillaumeGomez
Copy link
Member Author

@GuillaumeGomez GuillaumeGomez commented Oct 21, 2019

@EPashkin It's set_detail_func.

@GuillaumeGomez
Copy link
Member Author

@GuillaumeGomez GuillaumeGomez commented Oct 21, 2019

Ok, extended it a bit. Doesn't have warning on gstreamer-editing-services anymore.

@EPashkin I'm removing the imports from the callbacks only so that should be pretty accurate.

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Oct 21, 2019

@GuillaumeGomez Now I understand that, thanks.

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Oct 21, 2019

Last change broke gio's g_settings_schema_source_list_schemas

@GuillaumeGomez
Copy link
Member Author

@GuillaumeGomez GuillaumeGomez commented Oct 21, 2019

Interesting! I'll take a look.

@GuillaumeGomez
Copy link
Member Author

@GuillaumeGomez GuillaumeGomez commented Oct 21, 2019

It now works on gio as well. :)

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Oct 21, 2019

@GuillaumeGomez Yes, not only needed changes. Thanks.

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Oct 21, 2019

  • now only needed changes

@EPashkin
Copy link
Member

@EPashkin EPashkin commented Oct 22, 2019

Lets merge

@EPashkin EPashkin merged commit ecd0564 into gtk-rs:master Oct 22, 2019
2 checks passed
@GuillaumeGomez GuillaumeGomez deleted the invalid-import-add branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants