Correctly generate glib::Error import #863
Merged
+31
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Oct 23, 2019
src/analysis/imports.rs
Outdated
| fn strip_crate_name<'a>(&self, name: &'a str) -> Option<&'a str> { | ||
| fn strip_crate_name<'a>(&self, mut name: &'a str) -> Option<&'a str> { | ||
| if name == "Error" && self.crate_name != "glib" { | ||
| name = "glib::Error"; |
There was a problem hiding this comment.
This does not seem correct. Why does it even end up here without the glib:: prefix?
There was a problem hiding this comment.
This is actually an excellent question. Since it's part of manual imports everytime, it *should* not be needed. This fix is therefore incomplete. I need to find what's going on.
GuillaumeGomez
force-pushed
the
correct-error-import
branch
from
0a78a3c to
1321e31
Compare
|
I now extended the fix. Way cleaner, better, faster, etc. :) |
GuillaumeGomez
force-pushed
the
correct-error-import
branch
from
1321e31 to
03f218f
Compare
|
And now with fixed formatting. |
|
@GuillaumeGomez Thanks, I will wait for @sdroege just in case |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #862.
cc @EPashkin @sdroege @Ekleog