New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gir files zesty #141

Merged
merged 3 commits into from Nov 26, 2016

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Nov 26, 2016

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 26, 2016

Member

Is it normal that the submodule reference isn't working in travis?

Member

GuillaumeGomez commented Nov 26, 2016

Is it normal that the submodule reference isn't working in travis?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 26, 2016

Member

Yes normal, it still not merged gtk-rs/gir-files#2

Member

EPashkin commented Nov 26, 2016

Yes normal, it still not merged gtk-rs/gir-files#2

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 26, 2016

Member

Ok, now it's all good!

Member

GuillaumeGomez commented Nov 26, 2016

Ok, now it's all good!

@GuillaumeGomez GuillaumeGomez merged commit cba1016 into gtk-rs:master Nov 26, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 26, 2016

Member

@GuillaumeGomez, dependent PRs better don't merge if you don't want publish all gtk-rs crate,
as currently its use more features.

Member

EPashkin commented Nov 26, 2016

@GuillaumeGomez, dependent PRs better don't merge if you don't want publish all gtk-rs crate,
as currently its use more features.

@EPashkin EPashkin deleted the EPashkin:gir_files_zesty branch Nov 26, 2016

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 26, 2016

Member

.. and I currently don't see way to build crates dependent on unpublished feature

Member

EPashkin commented Nov 26, 2016

.. and I currently don't see way to build crates dependent on unpublished feature

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 26, 2016

Member

Oops, forgot that it just "Test PR",

Member

EPashkin commented Nov 26, 2016

Oops, forgot that it just "Test PR",

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 26, 2016

Member

.. to do normal I need update gir-files and do full regen.
Previous comment apply to final version.

Member

EPashkin commented Nov 26, 2016

.. to do normal I need update gir-files and do full regen.
Previous comment apply to final version.

@EPashkin EPashkin referenced this pull request Nov 26, 2016

Merged

Gir files zesty #142

sdroege pushed a commit to sdroege/glib-rs that referenced this pull request Sep 14, 2018

Merge pull request gtk-rs#141 from sdroege/nll
Fix compilation with two-phase-borrows (aka NLL)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment