New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard derive for SourceId. #146

Merged
merged 1 commit into from Feb 26, 2017

Conversation

Projects
None yet
3 participants
@hfiguiere
Contributor

hfiguiere commented Feb 26, 2017

I forgot the standard derivce on SourceId. Which is making it harder to use.

Show outdated Hide outdated src/source.rs Outdated
@hfiguiere

This comment has been minimized.

Show comment
Hide comment
@hfiguiere

hfiguiere Feb 26, 2017

Contributor

Added comment.

Also move from_glib() into unsafe{} as per gtk-rs/gtk#455 (comment)

Contributor

hfiguiere commented Feb 26, 2017

Added comment.

Also move from_glib() into unsafe{} as per gtk-rs/gtk#455 (comment)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 26, 2017

Member

Thanks! Please squash your commits now. ;)

@EPashkin: anything to add?

Member

GuillaumeGomez commented Feb 26, 2017

Thanks! Please squash your commits now. ;)

@EPashkin: anything to add?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 26, 2017

Member

All seems good for me.

Member

EPashkin commented Feb 26, 2017

All seems good for me.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 26, 2017

Member

Perfect then! Just remaining the squash. If you don't know how to do it, take a look here.

Member

GuillaumeGomez commented Feb 26, 2017

Perfect then! Just remaining the squash. If you don't know how to do it, take a look here.

Standard derive for SourceId.
Move from_glib() inside the unsafe{} block to be consistent with
a requested change in gtk-rs
@hfiguiere

This comment has been minimized.

Show comment
Hide comment
@hfiguiere

hfiguiere Feb 26, 2017

Contributor

commit squashed.

Contributor

hfiguiere commented Feb 26, 2017

commit squashed.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 26, 2017

Member

Perfect, thanks!

Member

GuillaumeGomez commented Feb 26, 2017

Perfect, thanks!

@GuillaumeGomez GuillaumeGomez merged commit 3be8b89 into gtk-rs:master Feb 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment