New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crates in master, update versions #151

Merged
merged 5 commits into from Mar 11, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Mar 11, 2017

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 11, 2017

Member

I'm not sure to understand the point of this PR:

  • We won't update crates' version every time we merge a PR in sys crates.
  • It won't test new changes from sys crates.

Isn't it a bad things going this way?

Member

GuillaumeGomez commented Mar 11, 2017

I'm not sure to understand the point of this PR:

  • We won't update crates' version every time we merge a PR in sys crates.
  • It won't test new changes from sys crates.

Isn't it a bad things going this way?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 11, 2017

Member
  • due "^0.3.3" glib uses latest crate up to (but not including) 0.4.0 see
  • glib build examples pending branch to test and it contains replacement to git version
Member

EPashkin commented Mar 11, 2017

  • due "^0.3.3" glib uses latest crate up to (but not including) 0.4.0 see
  • glib build examples pending branch to test and it contains replacement to git version
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 11, 2017

Member

Hum, ok. Should we make a new release as well (on crates.io)?

Member

GuillaumeGomez commented Mar 11, 2017

Hum, ok. Should we make a new release as well (on crates.io)?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 11, 2017

Member

IMHO better wait until you done with IsA and do release as planned.
This way we testing that this method really works 😉

Member

EPashkin commented Mar 11, 2017

IMHO better wait until you done with IsA and do release as planned.
This way we testing that this method really works 😉

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 11, 2017

Member

Ok! When you think everything is ok, just ping me on every PR then (won't have much time today) and I'll try to merge them quickly.

Member

GuillaumeGomez commented Mar 11, 2017

Ok! When you think everything is ok, just ping me on every PR then (won't have much time today) and I'll try to merge them quickly.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 11, 2017

Member

Can you go to end of gtk-rs/examples#112 and merge it by references?

Member

EPashkin commented Mar 11, 2017

Can you go to end of gtk-rs/examples#112 and merge it by references?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 11, 2017

Member

Let's do it then!

Member

GuillaumeGomez commented Mar 11, 2017

Let's do it then!

@GuillaumeGomez GuillaumeGomez merged commit 549d7ea into gtk-rs:master Mar 11, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment