New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array of string full transfer #153

Merged
merged 1 commit into from Mar 15, 2017

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented Mar 15, 2017

Fix gtk-rs/gtk#469

@Susurrus check this please.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 15, 2017

Member

Well:

if num == 0 || ptr.is_null() {
    return Vec::new()
}

So impossible to be null, indeed.

Member

GuillaumeGomez commented Mar 15, 2017

Well:

if num == 0 || ptr.is_null() {
    return Vec::new()
}

So impossible to be null, indeed.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 15, 2017

Member

Fixed

Member

EPashkin commented Mar 15, 2017

Fixed

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 15, 2017

Member

Thanks!

Member

GuillaumeGomez commented Mar 15, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 6dabedc into gtk-rs:master Mar 15, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@EPashkin EPashkin deleted the EPashkin:g_resource_enumerate_children branch Mar 15, 2017

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 15, 2017

Member

Strange, appveyour do 2 builds per "action".

Member

EPashkin commented Mar 15, 2017

Strange, appveyour do 2 builds per "action".

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 15, 2017

Member

Travis too some times. Dark magic and stuff.

Member

GuillaumeGomez commented Mar 15, 2017

Travis too some times. Dark magic and stuff.

@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Mar 15, 2017

Looks like this fixed my code example. Thanks!

Susurrus commented Mar 15, 2017

Looks like this fixed my code example. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment