New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite string consts #155

Merged
merged 1 commit into from Apr 5, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Apr 5, 2017

Preparation for apply gtk-rs/gir#339
cc @GuillaumeGomez, @sdroege

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 5, 2017

Member

This will fail

Member

EPashkin commented Apr 5, 2017

This will fail

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 5, 2017

Member

Hum... The output isn't very readable but otherwise it's a great idea! 👍

Member

GuillaumeGomez commented Apr 5, 2017

Hum... The output isn't very readable but otherwise it's a great idea! 👍

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 5, 2017

Member

As only glib affected we can always change this do direct string,

Member

EPashkin commented Apr 5, 2017

As only glib affected we can always change this do direct string,

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 5, 2017

Member

@GuillaumeGomez merge this please, I add to sys.

Member

EPashkin commented Apr 5, 2017

@GuillaumeGomez merge this please, I add to sys.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented Apr 5, 2017

Sure.

@GuillaumeGomez GuillaumeGomez merged commit 8271fc3 into gtk-rs:master Apr 5, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@EPashkin EPashkin deleted the EPashkin:rewrite_string_consts branch Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment