New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use g_object_ref_sink() instead of g_object_ref() everywhere #167

Merged
merged 1 commit into from May 12, 2017

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented May 11, 2017

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 12, 2017

Member

@GuillaumeGomez please take look at this PR and related issue.
IMHO it can be merged without problem

Member

EPashkin commented May 12, 2017

@GuillaumeGomez please take look at this PR and related issue.
IMHO it can be merged without problem

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 12, 2017

Member

The famous floating reference. Already spoke a bit about it with @sdroege. I agree with the change as well so let's merge it.

Thanks!

Member

GuillaumeGomez commented May 12, 2017

The famous floating reference. Already spoke a bit about it with @sdroege. I agree with the change as well so let's merge it.

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 9a2bfb1 into gtk-rs:master May 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment