New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate global functions #170

Merged
merged 1 commit into from May 20, 2017

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented May 18, 2017

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 18, 2017

Member

Waiting for appveyor to finish and then I merge.

Member

GuillaumeGomez commented May 18, 2017

Waiting for appveyor to finish and then I merge.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 18, 2017

Member

Don't forget gtk's PR ;)

Member

EPashkin commented May 18, 2017

Don't forget gtk's PR ;)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 18, 2017

Member

Ah damn, you're right!

Member

GuillaumeGomez commented May 18, 2017

Ah damn, you're right!

@@ -4,19 +4,6 @@
use ffi;
use translate::*;
use UserDirectory;
pub fn get_application_name() -> Option<String> {

This comment has been minimized.

@sdroege

sdroege May 18, 2017

Member

While all these functions are in auto/functions.rs, I don't see them re-exported from lib.rs anywhere

@sdroege

sdroege May 18, 2017

Member

While all these functions are in auto/functions.rs, I don't see them re-exported from lib.rs anywhere

This comment has been minimized.

@EPashkin

EPashkin May 18, 2017

Member

It can be used by long name

@EPashkin

EPashkin May 18, 2017

Member

It can be used by long name

This comment has been minimized.

@sdroege

sdroege May 18, 2017

Member

But previously it was available as e.g. utils::get_application_name(). Now it would be auto::functions::get_application_name() (and the auto module is not pub-re-exported so that won't work)

edit: actually it is pub-re-exported. But nonetheless, this would be an API change that does not seem needed, and also doesn't seem ideal from a user-experience point of view :)

@sdroege

sdroege May 18, 2017

Member

But previously it was available as e.g. utils::get_application_name(). Now it would be auto::functions::get_application_name() (and the auto module is not pub-re-exported so that won't work)

edit: actually it is pub-re-exported. But nonetheless, this would be an API change that does not seem needed, and also doesn't seem ideal from a user-experience point of view :)

This comment has been minimized.

@EPashkin

EPashkin May 18, 2017

Member

Hm, you right. I missed fact that auto non public in all crates :(
What better do: add to lib.rs pub mod functions with reexports or something else?
@GuillaumeGomez maybe you have better idea?

@EPashkin

EPashkin May 18, 2017

Member

Hm, you right. I missed fact that auto non public in all crates :(
What better do: add to lib.rs pub mod functions with reexports or something else?
@GuillaumeGomez maybe you have better idea?

This comment has been minimized.

@EPashkin

EPashkin May 18, 2017

Member

Or just make auto public?

@EPashkin

EPashkin May 18, 2017

Member

Or just make auto public?

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez May 20, 2017

Member

We never target a specific date. When we judge we have enough changes or someone really want/need a release to publish his/her crate, we do it.

@GuillaumeGomez

GuillaumeGomez May 20, 2017

Member

We never target a specific date. When we judge we have enough changes or someone really want/need a release to publish his/her crate, we do it.

This comment has been minimized.

@sdroege

sdroege May 20, 2017

Member

Makes sense :) before a big release, it might be a good idea to do a small release with the floating reference bugfix, just of glib.

@sdroege

sdroege May 20, 2017

Member

Makes sense :) before a big release, it might be a good idea to do a small release with the floating reference bugfix, just of glib.

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez May 20, 2017

Member

There is no such things as a small release (because it takes a lot of time to make one).

@GuillaumeGomez

GuillaumeGomez May 20, 2017

Member

There is no such things as a small release (because it takes a lot of time to make one).

This comment has been minimized.

@sdroege

sdroege May 20, 2017

Member

It's not possible to just "cargo publish" glib with a new version number and that patch, and keep everything else the same?

@sdroege

sdroege May 20, 2017

Member

It's not possible to just "cargo publish" glib with a new version number and that patch, and keep everything else the same?

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez May 20, 2017

Member

Hum, might be actually.

@GuillaumeGomez

GuillaumeGomez May 20, 2017

Member

Hum, might be actually.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 20, 2017

Member

This is last for reexport

Member

EPashkin commented May 20, 2017

This is last for reexport

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 20, 2017

Member

And thanks!

Member

GuillaumeGomez commented May 20, 2017

And thanks!

@GuillaumeGomez GuillaumeGomez merged commit 85bf54a into gtk-rs:master May 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:functions branch May 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment