New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BoolError constructor public #179

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Jun 6, 2017

Allows retrieving the string by matching or constructing BoolErrors
without the from_glib() helper function

Make BoolError constructor public
Allows retrieving the string by matching or constructing BoolErrors
without the from_glib() helper function
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 6, 2017

Member

IMHO better add getter

Member

EPashkin commented Jun 6, 2017

IMHO better add getter

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 6, 2017

Member

IMHO better add getter

See gtk-rs/gtk#523 for another reason. Alternatively we could also add a getter and new() function, but that seems like it has no advantage and just adds noise.

Member

sdroege commented Jun 6, 2017

IMHO better add getter

See gtk-rs/gtk#523 for another reason. Alternatively we could also add a getter and new() function, but that seems like it has no advantage and just adds noise.

@GuillaumeGomez GuillaumeGomez merged commit 050656d into gtk-rs:master Jun 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 6, 2017

Member

Well, it doesn't harm to have it. Thanks!

Member

GuillaumeGomez commented Jun 6, 2017

Well, it doesn't harm to have it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment