-
-
Notifications
You must be signed in to change notification settings - Fork 62
Conversation
@@ -223,7 +223,7 @@ impl KeyFile { | |||
} | |||
} | |||
|
|||
//pub fn set_boolean_list(&self, group_name: &str, key: &str, list: /*Unimplemented*/&CArray TypeId { ns_id: 0, id: 1 }, length: usize) { | |||
//pub fn set_boolean_list(&self, group_name: &str, key: &str, list: /*Unimplemented*/&CArray TypeId { ns_id: 0, id: 1 }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set_string_list() will be fixed with the next GLib .gir update. set_list() and get_list() requires non-ptr container support.
Seems |
Done. But I'm wondering, the UTF8 variants use UTF8 for filenames/paths but std::path::PathBuf is in the local encoding, or not? Also this function could as well be hidden, the Rust url crate has this as a pure Rust implementation. |
Checked that function works on Windows. |
Tomorrow I'm on a plane so if you don't have answer from me, please ping me. |
Ok with me to keep it, it just doesn't seem very useful to me :) |
Related to gtk-rs/gir#376 |
Well, keeping them doesn't hurt so unless there's a huge reason to remove them, I'm more in favor to keep them. |
@sdroege, as It still don't merged, can you apply gtk-rs/gir#392 too ? |
Sure, and also the others |
This comes with a _utf8() suffix on Windows.
Done |
Thanks again, @sdroege |
Thanks! |
Oops, sorry! #185 The other pull requests got updated to also have gir updated correctly. |
No description provided.