New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate with latest gir #184

Merged
merged 2 commits into from Jun 25, 2017

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Jun 22, 2017

No description provided.

@@ -223,7 +223,7 @@ impl KeyFile {
}
}
//pub fn set_boolean_list(&self, group_name: &str, key: &str, list: /*Unimplemented*/&CArray TypeId { ns_id: 0, id: 1 }, length: usize) {
//pub fn set_boolean_list(&self, group_name: &str, key: &str, list: /*Unimplemented*/&CArray TypeId { ns_id: 0, id: 1 }) {

This comment has been minimized.

@sdroege

sdroege Jun 22, 2017

Member

set_string_list() will be fixed with the next GLib .gir update. set_list() and get_list() requires non-ptr container support.

@sdroege

sdroege Jun 22, 2017

Member

set_string_list() will be fixed with the next GLib .gir update. set_list() and get_list() requires non-ptr container support.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 22, 2017

Member

Seems g_filename_from_uri need be manual as filename_to_uri

Member

EPashkin commented Jun 22, 2017

Seems g_filename_from_uri need be manual as filename_to_uri

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 23, 2017

Member

Done. But I'm wondering, the UTF8 variants use UTF8 for filenames/paths but std::path::PathBuf is in the local encoding, or not?

Also this function could as well be hidden, the Rust url crate has this as a pure Rust implementation.

Member

sdroege commented Jun 23, 2017

Done. But I'm wondering, the UTF8 variants use UTF8 for filenames/paths but std::path::PathBuf is in the local encoding, or not?

Also this function could as well be hidden, the Rust url crate has this as a pure Rust implementation.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 23, 2017

Member

Checked that function works on Windows.
https://github.com/gtk-rs/glib/blob/master/src/translate.rs#L399-L410
and https://github.com/gtk-rs/glib/blob/master/src/translate.rs#L782-L793 handles conversion.
IMHO better don't ignore, but final decision on @GuillaumeGomez
Thanks, @sdroege

Member

EPashkin commented Jun 23, 2017

Checked that function works on Windows.
https://github.com/gtk-rs/glib/blob/master/src/translate.rs#L399-L410
and https://github.com/gtk-rs/glib/blob/master/src/translate.rs#L782-L793 handles conversion.
IMHO better don't ignore, but final decision on @GuillaumeGomez
Thanks, @sdroege

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 23, 2017

Member

Tomorrow I'm on a plane so if you don't have answer from me, please ping me.

Member

GuillaumeGomez commented Jun 23, 2017

Tomorrow I'm on a plane so if you don't have answer from me, please ping me.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 24, 2017

Member

Ok with me to keep it, it just doesn't seem very useful to me :)

Member

sdroege commented Jun 24, 2017

Ok with me to keep it, it just doesn't seem very useful to me :)

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 24, 2017

Member

Related to gtk-rs/gir#376

Member

sdroege commented Jun 24, 2017

Related to gtk-rs/gir#376

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 24, 2017

Member

Well, keeping them doesn't hurt so unless there's a huge reason to remove them, I'm more in favor to keep them.

Member

GuillaumeGomez commented Jun 24, 2017

Well, keeping them doesn't hurt so unless there's a huge reason to remove them, I'm more in favor to keep them.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 24, 2017

Member

@sdroege, as It still don't merged, can you apply gtk-rs/gir#392 too ?

Member

EPashkin commented Jun 24, 2017

@sdroege, as It still don't merged, can you apply gtk-rs/gir#392 too ?

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 25, 2017

Member

Sure, and also the others

Member

sdroege commented Jun 25, 2017

Sure, and also the others

sdroege added some commits Jun 22, 2017

Manually write g_filename_from_uri() bindings
This comes with a _utf8() suffix on Windows.
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 25, 2017

Member

Done

Member

sdroege commented Jun 25, 2017

Done

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 25, 2017

Member

Thanks again, @sdroege
👍 for merge

Member

EPashkin commented Jun 25, 2017

Thanks again, @sdroege
👍 for merge

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 25, 2017

Member

Thanks!

Member

GuillaumeGomez commented Jun 25, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 596f8ae into gtk-rs:master Jun 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 25, 2017

Member

Oops, sorry! #185

The other pull requests got updated to also have gir updated correctly.

Member

sdroege commented Jun 25, 2017

Oops, sorry! #185

The other pull requests got updated to also have gir updated correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment