Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Regenerate with latest gir #184

Merged
merged 2 commits into from
Jun 25, 2017
Merged

Regenerate with latest gir #184

merged 2 commits into from
Jun 25, 2017

Conversation

sdroege
Copy link
Member

@sdroege sdroege commented Jun 22, 2017

No description provided.

@@ -223,7 +223,7 @@ impl KeyFile {
}
}

//pub fn set_boolean_list(&self, group_name: &str, key: &str, list: /*Unimplemented*/&CArray TypeId { ns_id: 0, id: 1 }, length: usize) {
//pub fn set_boolean_list(&self, group_name: &str, key: &str, list: /*Unimplemented*/&CArray TypeId { ns_id: 0, id: 1 }) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_string_list() will be fixed with the next GLib .gir update. set_list() and get_list() requires non-ptr container support.

@EPashkin
Copy link
Member

Seems g_filename_from_uri need be manual as filename_to_uri

@sdroege
Copy link
Member Author

sdroege commented Jun 23, 2017

Done. But I'm wondering, the UTF8 variants use UTF8 for filenames/paths but std::path::PathBuf is in the local encoding, or not?

Also this function could as well be hidden, the Rust url crate has this as a pure Rust implementation.

@EPashkin
Copy link
Member

Checked that function works on Windows.
https://github.com/gtk-rs/glib/blob/master/src/translate.rs#L399-L410
and https://github.com/gtk-rs/glib/blob/master/src/translate.rs#L782-L793 handles conversion.
IMHO better don't ignore, but final decision on @GuillaumeGomez
Thanks, @sdroege

@GuillaumeGomez
Copy link
Member

Tomorrow I'm on a plane so if you don't have answer from me, please ping me.

@sdroege
Copy link
Member Author

sdroege commented Jun 24, 2017

Ok with me to keep it, it just doesn't seem very useful to me :)

@sdroege
Copy link
Member Author

sdroege commented Jun 24, 2017

Related to gtk-rs/gir#376

@GuillaumeGomez
Copy link
Member

Well, keeping them doesn't hurt so unless there's a huge reason to remove them, I'm more in favor to keep them.

@EPashkin
Copy link
Member

@sdroege, as It still don't merged, can you apply gtk-rs/gir#392 too ?

@sdroege
Copy link
Member Author

sdroege commented Jun 25, 2017

Sure, and also the others

@sdroege
Copy link
Member Author

sdroege commented Jun 25, 2017

Done

@EPashkin
Copy link
Member

Thanks again, @sdroege
👍 for merge

@GuillaumeGomez
Copy link
Member

Thanks!

@sdroege
Copy link
Member Author

sdroege commented Jun 25, 2017

Oops, sorry! #185

The other pull requests got updated to also have gir updated correctly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants