New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement StaticType and GValue traits for boxed/shared types too #199

Merged
merged 1 commit into from Jul 19, 2017

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Jul 18, 2017

As long as a get_type() function is provided to the macro.

Implement StaticType and GValue traits for boxed/shared types too
As long as a get_type() function is provided to the macro.
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 18, 2017

Member

This should be ready too now, and is needed for gtk-rs/gir#410

CI is unhappy though, which looks like out of memory or timeouts... before this PR already.

Member

sdroege commented Jul 18, 2017

This should be ready too now, and is needed for gtk-rs/gir#410

CI is unhappy though, which looks like out of memory or timeouts... before this PR already.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 18, 2017

Member

Restarted CI.

Member

GuillaumeGomez commented Jul 18, 2017

Restarted CI.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 19, 2017

Member

@GuillaumeGomez 👍 for merge this PR despite CI internal problem
@sdroege, thanks.

Member

EPashkin commented Jul 19, 2017

@GuillaumeGomez 👍 for merge this PR despite CI internal problem
@sdroege, thanks.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 19, 2017

Member

Thanks!

Member

GuillaumeGomez commented Jul 19, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 167baa7 into gtk-rs:master Jul 19, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment