New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make glib::Error Send/Sync #203

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
4 participants
@hasufell
Contributor

hasufell commented Jul 21, 2017

This should be thread-safe since all fields are
"primitive" types, except for the message C string, which
is immutable.

Fixes #195

Make glib::Error Send/Sync
This should be thread-safe since all fields are
"primitive" types, except for the message C string, which
is immutable.

Fixes #195
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 21, 2017

Member

👍

Member

sdroege commented Jul 21, 2017

👍

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 21, 2017

Member

Seems travis build problem from massive memory usage (my build examples gone up 7gb)

Member

EPashkin commented Jul 21, 2017

Seems travis build problem from massive memory usage (my build examples gone up 7gb)

@hasufell

This comment has been minimized.

Show comment
Hide comment
@hasufell

hasufell Jul 21, 2017

Contributor

(my build examples gone up 7gb)

at least it's not over 9000

Contributor

hasufell commented Jul 21, 2017

(my build examples gone up 7gb)

at least it's not over 9000

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 21, 2017

Member

👍 Too
Thanks, @hasufell

Member

EPashkin commented Jul 21, 2017

👍 Too
Thanks, @hasufell

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 21, 2017

Member

Thanks!

Member

GuillaumeGomez commented Jul 21, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 8ac08ba into gtk-rs:master Jul 21, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 21, 2017

Member

Seems travis build problem from massive memory usage (my build examples gone up 7gb)

I wonder where they come. Most likely from the new trait impls added by the macros, but that needs some debugging at the rustc level... seems wrong

Member

sdroege commented Jul 21, 2017

Seems travis build problem from massive memory usage (my build examples gone up 7gb)

I wonder where they come. Most likely from the new trait impls added by the macros, but that needs some debugging at the rustc level... seems wrong

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 21, 2017

Member

This should be thread-safe since all fields are
"primitive" types, except for the message C string, which
is immutable.

The whole GError struct is immutable. It's created once, and changing any of the fields is an error

Member

sdroege commented Jul 21, 2017

This should be thread-safe since all fields are
"primitive" types, except for the message C string, which
is immutable.

The whole GError struct is immutable. It's created once, and changing any of the fields is an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment