New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some helper API to dynamically work with GLib enums/flags #207

Merged
merged 5 commits into from Aug 1, 2017

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Jul 30, 2017

See commits

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 30, 2017

Member

We have a big lack of documentation in here!

Member

GuillaumeGomez commented Jul 30, 2017

We have a big lack of documentation in here!

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 30, 2017

Member

That's very true :) I can write documentation when you tell me that the API is good as-is

Member

sdroege commented Jul 30, 2017

That's very true :) I can write documentation when you tell me that the API is good as-is

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 30, 2017

Member

So, it seems good for me as is. My only concern is that I miss something because I don't have idea where to use this code for the moment.

Member

GuillaumeGomez commented Jul 30, 2017

So, it seems good for me as is. My only concern is that I miss something because I don't have idea where to use this code for the moment.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 30, 2017

Member

@sdroege IMHO API is good.

Member

EPashkin commented Jul 30, 2017

@sdroege IMHO API is good.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 30, 2017

Member

My only concern is that I miss something because I don't have idea where to use this code for the moment.

https://gist.github.com/sdroege/46868640122e373c814b593652878f79#file-playbin-rs-L24 would be an example of flags usage

Member

sdroege commented Jul 30, 2017

My only concern is that I miss something because I don't have idea where to use this code for the moment.

https://gist.github.com/sdroege/46868640122e373c814b593652878f79#file-playbin-rs-L24 would be an example of flags usage

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 30, 2017

Member

Thanks for looking and the very fast feedback, I'll get docs written tomorrow then :)

Member

sdroege commented Jul 30, 2017

Thanks for looking and the very fast feedback, I'll get docs written tomorrow then :)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 30, 2017

Member

Thanks! :)

Member

GuillaumeGomez commented Jul 30, 2017

Thanks! :)

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 31, 2017

Member

Docs added

Member

sdroege commented Jul 31, 2017

Docs added

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Aug 1, 2017

Member

Anything you want to have added/clarified in the docs or does it look ok?

Member

sdroege commented Aug 1, 2017

Anything you want to have added/clarified in the docs or does it look ok?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 1, 2017

Member

No, that's all good. Since @EPashkin already gave his approval, we can merge. Thanks again!

Member

GuillaumeGomez commented Aug 1, 2017

No, that's all good. Since @EPashkin already gave his approval, we can merge. Thanks again!

@GuillaumeGomez GuillaumeGomez merged commit a4f23b2 into gtk-rs:master Aug 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment