New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version for Sha384 #227

Merged
merged 1 commit into from Sep 2, 2017

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented Sep 1, 2017

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Sep 1, 2017

Member

glib\gchecksum.h says @G_CHECKSUM_SHA384: Use the SHA-384 hashing algorithm (Since: 2.51),
but as I remember, gtk used even published version

Member

EPashkin commented Sep 1, 2017

glib\gchecksum.h says @G_CHECKSUM_SHA384: Use the SHA-384 hashing algorithm (Since: 2.51),
but as I remember, gtk used even published version

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Sep 1, 2017

Member

So what should we do about it?

Member

GuillaumeGomez commented Sep 1, 2017

So what should we do about it?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Sep 1, 2017

Member

Nothing if gtk publish policy not changed.

Member

EPashkin commented Sep 1, 2017

Nothing if gtk publish policy not changed.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Sep 1, 2017

Member

I'll have to make a new release way more early than expected.

Member

GuillaumeGomez commented Sep 1, 2017

I'll have to make a new release way more early than expected.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Sep 1, 2017

Member

But not too early 😉, all other crates also need update features, I forgot about it.

Member

EPashkin commented Sep 1, 2017

But not too early 😉, all other crates also need update features, I forgot about it.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Sep 1, 2017

Member

I'll have to make a new release way more early than expected.

Why? This was just added with the last PR and is not in the release :)

Nothing if gtk publish policy not changed.

It didn't, you can put 2.52 there

Member

sdroege commented Sep 1, 2017

I'll have to make a new release way more early than expected.

Why? This was just added with the last PR and is not in the release :)

Nothing if gtk publish policy not changed.

It didn't, you can put 2.52 there

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Sep 2, 2017

Member

@GuillaumeGomez, then this ready to merge.
About updating features in other crates: I will add PRs or better wait until you publish crates with GtkWindow-fix?

Member

EPashkin commented Sep 2, 2017

@GuillaumeGomez, then this ready to merge.
About updating features in other crates: I will add PRs or better wait until you publish crates with GtkWindow-fix?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Sep 2, 2017

Member

Since it's another "major" release, I'll wait a few weeks at least.

Member

GuillaumeGomez commented Sep 2, 2017

Since it's another "major" release, I'll wait a few weeks at least.

@GuillaumeGomez GuillaumeGomez merged commit f0a2aae into gtk-rs:master Sep 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:checksum_384_version_fix branch Sep 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment