New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Type improvements and bugfix for Object::connect() #260

Merged
merged 5 commits into from Nov 20, 2017

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Nov 20, 2017

No description provided.

sdroege added some commits Nov 20, 2017

Implement some new API for Type
is_a() for checking subtyping relationships, parent() for getting the
parent type if any, children() for getting all child types, interfaces()
for getting all interfaces implemented by the type and finally
interface_prerequisites() for getting all prerequisites of an interface
type.
Panic if the return value from the closure passed to Object::connect(…
…) returns a value of the wrong type

Or no value at all if a return value is needed, or a value if no return
value is needed.

By previously silently ignoring type errors here, hard to debug problems
appeared when code didn't get any meaningful return values.
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Nov 20, 2017

Member

@EPashkin @GuillaumeGomez Makes sense to you?

Member

sdroege commented Nov 20, 2017

@EPashkin @GuillaumeGomez Makes sense to you?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 20, 2017

Member

@sdroege Looks good, thanks

Member

EPashkin commented Nov 20, 2017

@sdroege Looks good, thanks

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 20, 2017

Member

Thanks!

Member

GuillaumeGomez commented Nov 20, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 4ba0412 into gtk-rs:master Nov 20, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment