New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ToGlibContainerFromSlice impls for strings, boxed/object/shared s… #270

Merged
merged 1 commit into from Dec 5, 2017

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Dec 5, 2017

…tructs

It was missing parenthesis, so instead of a NULL pointer at the end
there was only a single NULL byte

This is likely the cause for the critical warnings on travis during the tests @EPashkin @GuillaumeGomez

Fix ToGlibContainerFromSlice impls for strings, boxed/object/shared s…
…tructs

It was missing parenthesis, so instead of a NULL pointer at the end
there was only a single NULL byte
@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Dec 5, 2017

Outch. Not good, thanks a lot for the fix! (so common in C malloc calls...) Once CIs passed, I merge.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 5, 2017

Bad that it don't fix errors, but big thanks for finding this.

@sdroege

This comment has been minimized.

Member

sdroege commented Dec 5, 2017

so common in C malloc calls...

That's why there's g_new and related in GLib :)

Bad that it don't fix errors, but big thanks for finding this.

Then it needs someone to actually be able to reproduce it and get me a backtrace. I have no idea where it could come from in anything that is run by the tests :(

@GuillaumeGomez GuillaumeGomez merged commit dcefca8 into gtk-rs:master Dec 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sdroege

This comment has been minimized.

Member

sdroege commented Dec 6, 2017

I have a similar case in GStreamer btw: https://travis-ci.org/sdroege/gstreamer-rs/jobs/312082352#L800

This one I also can't reproduce locally, it only seems to happen on travis.

@sdroege

This comment has been minimized.

Member

sdroege commented Dec 6, 2017

Ah, this is it: https://bugzilla.gnome.org/show_bug.cgi?id=755766

Problem is that travis uses an ancient GLib version. But we can work-around that, let me send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment